Give Every Service a Shared HTTP Client: PR Review

Every team configures HTTP clients differently, and two incidents last quarter came from calls with no timeout. This adds platform-http, a shared OkHttp client with a 30 second timeout, retries with exponential backoff on IOExceptions and 5xx responses, and a metrics interceptor. platform-core 5.0 registers it as the default client, so the BOM bump moves all 41 services onto it at their next build with no code changes.

Aplatform-http/src/main/java/com/acme/platform/http/PlatformHttpClient.java1 of 3

Files Changed

platform-http/src/main/java/com/acme/platform/http/

platform-bom/

platform-http/src/main/java/com/acme/platform/http/PlatformHttpClient.java

Java · Click a line number to comment · Tap a line to comment

@@ -0,0 +1,46 @@

package com.acme.platform.http;

import java.io.IOException;

import java.time.Duration;

import okhttp3.Interceptor;

import okhttp3.OkHttpClient;

import okhttp3.Response;

/** The HTTP client every service gets from the platform BOM. */

public final class PlatformHttpClient {

static final int MAX_RETRIES = 5;

static final Duration TIMEOUT = Duration.ofSeconds(30);

public static OkHttpClient create() {

return new OkHttpClient.Builder()

.callTimeout(TIMEOUT)

.addInterceptor(PlatformHttpClient::retry)

.addInterceptor(new MetricsInterceptor())

.build();

}

static Response retry(Interceptor.Chain chain) throws IOException {

IOException last = null;

for (int attempt = 0; attempt <= MAX_RETRIES; attempt++) {

try {

Response response = chain.proceed(chain.request());

if (response.code() < 500) {

return response;

}

response.close();

} catch (IOException e) {

last = e;

}

sleep(100L << attempt);

}

throw last != null ? last : new IOException("retries exhausted");

}

private static void sleep(long millis) {

try {

Thread.sleep(millis);

} catch (InterruptedException e) {

Thread.currentThread().interrupt();

}

platform-http/src/main/java/com/acme/platform/http/PlatformHttpClient.java

platform-http/src/main/java/com/acme/platform/http/MetricsInterceptor.java

platform-bom/pom.xml