Tell Me About Code Review Feedback That Was Hard to Take
Behavioral and LeadershipReceiving FeedbackAsked atJuniorMidUpdated
“Tell me about a piece of code review feedback that was hard to take. What did you do with it?”
They're checking whether you learn from review. Strong answers name the feedback, show how you handled the thread, and point to a habit that changed.
Rubric by Level
Junior
- Names the specific feedback, like naming, structure, a missed edge case, or tests.
- Asked a clarifying question when you didn't understand, and stayed calm in the thread.
- Made the change and applied the lesson on the next PR.
- Names a habit that changed, like writing the test first or splitting PRs.
Mid
- Separated the feedback you agreed with from the parts you pushed back on, with reasons.
- Moved a long thread to a quick conversation.
- Shows the lesson turning up in your own reviews of others.
Senior
- The feedback challenged a design choice you owned, and you weighed it on the merits.
- Changed your mind in public when the reviewer was right.
- Turned a recurring comment into a lint rule, a checklist, or a shared guideline.
Principal
- Talks about feedback on a strategy or architecture bet from a peer or a skeptic.
- Shows you built review forums where hard feedback reaches you early.
- Names a decision you reversed or reshaped because of it.
Red Flags
- Argued in PR comments without taking it offline.
- Made the immediate change but didn't internalize the underlying point.
- Says the reviewer "didn't get it" without showing they tried to.
Follow-Ups to Expect
- Is there any part of that feedback you still disagree with?
- How do you give that kind of feedback to others now?
A Story Shape That Holds Up
The Comment
What the reviewer said, as close to their words as you can.
Your First Reaction
What you felt, and what you did in the thread.
The Change
What you fixed in that PR.
The Habit
What you do differently on every PR since.